-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVG defintions always take the first one #937
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @MorrisJobke, @DeepDiver1975 and @PVince81 to be potential reviewers |
🌀All magic 👍 |
Tests fail |
nickvergessen
added
2. developing
Work in progress
and removed
3. to review
Waiting for reviews
labels
Aug 18, 2016
Tested and works in Firefox, Chrome, Edge and IE11. 👍 |
Somehow the clone failed. I restarted it. |
Conflicts :( |
Um what:
Ah ... because of the conflicts. |
Let me try to resolve this. |
* Move filter definition out
MorrisJobke
force-pushed
the
fix_app_search
branch
from
August 18, 2016 14:16
65db2fe
to
59da597
Compare
Resolved. Still works 👍 |
MorrisJobke
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
2. developing
Work in progress
labels
Aug 18, 2016
GitHubUser4234
pushed a commit
to GitHubUser4234/server
that referenced
this pull request
Aug 30, 2016
SVG defintions always take the first one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #922
@MorrisJobke @nickvergessen please test