-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix jsunit tests #9407
Merged
Merged
Fix jsunit tests #9407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Codecov Report
@@ Coverage Diff @@
## master #9407 +/- ##
============================================
+ Coverage 51.1% 51.68% +0.57%
Complexity 25654 25654
============================================
Files 1569 1636 +67
Lines 88234 96176 +7942
Branches 0 1393 +1393
============================================
+ Hits 45095 49709 +4614
- Misses 43139 46467 +3328
|
MorrisJobke
approved these changes
May 7, 2018
skjnldsv
approved these changes
May 7, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weeee
This was referenced May 9, 2018
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like the behaviour changed somewhere between sinon version 5.0.1 and the current 5.0.5, but I could not find any reference in the changes.
Anyhow this fixes the jsunit tests in drone again. We should also backport this back to stable13/stable12, as it is broken there as well.
Please review @nextcloud/javascript