Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jsunit tests #9407

Merged
merged 1 commit into from
May 7, 2018
Merged

Fix jsunit tests #9407

merged 1 commit into from
May 7, 2018

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented May 7, 2018

Seems like the behaviour changed somewhere between sinon version 5.0.1 and the current 5.0.5, but I could not find any reference in the changes.

Anyhow this fixes the jsunit tests in drone again. We should also backport this back to stable13/stable12, as it is broken there as well.

Please review @nextcloud/javascript

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added 2. developing Work in progress bug 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 7, 2018
@juliusknorr juliusknorr added this to the Nextcloud 14 milestone May 7, 2018
@codecov
Copy link

codecov bot commented May 7, 2018

Codecov Report

Merging #9407 into master will increase coverage by 0.57%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9407      +/-   ##
============================================
+ Coverage      51.1%   51.68%   +0.57%     
  Complexity    25654    25654              
============================================
  Files          1569     1636      +67     
  Lines         88234    96176    +7942     
  Branches          0     1393    +1393     
============================================
+ Hits          45095    49709    +4614     
- Misses        43139    46467    +3328
Impacted Files Coverage Δ Complexity Δ
core/js/oc-dialogs.js 0.43% <0%> (ø) 0% <0%> (?)
core/js/oc-backbone.js 100% <0%> (ø) 0% <0%> (?)
core/js/config.js 6.66% <0%> (ø) 0% <0%> (?)
core/js/files/client.js 85.26% <0%> (ø) 0% <0%> (?)
core/js/l10n.js 97.29% <0%> (ø) 0% <0%> (?)
core/js/mimetypelist.js 100% <0%> (ø) 0% <0%> (?)
apps/files_sharing/js/public.js 47.91% <0%> (ø) 0% <0%> (?)
core/js/public/appconfig.js 4.76% <0%> (ø) 0% <0%> (?)
core/js/files/fileinfo.js 100% <0%> (ø) 0% <0%> (?)
apps/files_sharing/js/sharetabview.js 86.66% <0%> (ø) 0% <0%> (?)
... and 59 more

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weeee

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 7, 2018
@skjnldsv skjnldsv merged commit 94010e9 into master May 7, 2018
@skjnldsv skjnldsv deleted the fix-jsunit branch May 7, 2018 10:16
This was referenced May 9, 2018
@juliusknorr
Copy link
Member Author

stable12 #9431
stable13 #9430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants