Make sure the file is readable before attempting to create a preview #9666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
added
enhancement
3. to review
rullzer
requested review from
MorrisJobke,
icewind1991,
ChristophWurst,
blizzz and
danxuliu
This was referenced May 29, 2018
blizzz
approved these changes
May 30, 2018
|
It should not cause the failing integration test, or does it? |
icewind1991
approved these changes
May 30, 2018
Let's rebase and check if this get's green :) |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
MorrisJobke
added
4. to release
MorrisJobke
force-pushed
the
enhancement/noid/preview_check_file_readbale
branch
from
fa2885e to
14acded
Compare
Codecov Report
@@ Coverage Diff @@
## master #9666 +/- ##
============================================
+ Coverage 51.73% 51.73% +<.01%
- Complexity 25709 25710 +1
============================================
Files 1635 1635
Lines 95963 95965 +2
Branches 1384 1384
============================================
+ Hits 49646 49650 +4
+ Misses 46317 46315 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl