Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent search form submit #9954

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Prevent search form submit #9954

merged 1 commit into from
Jun 21, 2018

Conversation

skjnldsv
Copy link
Member

Fix #9943

@skjnldsv
Prevent search form submit
f4e988c 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added this to the Nextcloud 14 milestone Jun 21, 2018
@skjnldsv skjnldsv self-assigned this Jun 21, 2018
MorrisJobke
MorrisJobke approved these changes Jun 21, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

jancborchardt
jancborchardt approved these changes Jun 21, 2018
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now

@MorrisJobke MorrisJobke merged commit 7ab0335 into master Jun 21, 2018
@MorrisJobke MorrisJobke deleted the search-form-preventdefaults branch June 21, 2018 21:37
@MorrisJobke MorrisJobke mentioned this pull request Jun 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug feature: search regression
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @MorrisJobke @jancborchardt