Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added icons to users list and improved design #9962

Merged
merged 2 commits into from
Jun 22, 2018
Merged

Added icons to users list and improved design #9962

merged 2 commits into from
Jun 22, 2018

Conversation

skjnldsv
Copy link
Member

Fix #4589

capture d ecran_2018-06-22_09-47-29

@skjnldsv
Added icons to users list and improved design
bd4cba4 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added enhancement design Design, UI, UX, etc. 3. to review Waiting for reviews papercut Annoying recurring issue with possibly simple fix. feature: users and groups labels Jun 22, 2018
@skjnldsv skjnldsv added this to the Nextcloud 14 milestone Jun 22, 2018
@skjnldsv skjnldsv self-assigned this Jun 22, 2018
@skjnldsv
removed debug
006deec 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@codecov
Copy link

codecov bot commented Jun 22, 2018 •
edited
Loading

Codecov Report

Merging #9962 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #9962   +/-   ##
=========================================
  Coverage     52.07%   52.07%           
  Complexity    25946    25946           
=========================================
  Files          1645     1645           
  Lines         95839    95839           
  Branches       1290     1290           
=========================================
  Hits          49907    49907           
  Misses        45932    45932

jancborchardt
jancborchardt approved these changes Jun 22, 2018
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice, great work! :)

@jancborchardt
Copy link
Member

Super nice! :) (But we should probably ellipsize that username to one line? ;)

@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 22, 2018 •
edited
Loading

(But we should probably ellipsize that username to one line? ;)

#9644

@juliushaertl juliushaertl merged commit 11e73b7 into master Jun 22, 2018
@juliushaertl juliushaertl deleted the polish-user-list branch June 22, 2018 08:54
@nextcloud-bot nextcloud-bot mentioned this pull request Jul 9, 2018
Closed
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 22, 2018
Closed
This was referenced Oct 2, 2018
Closed
Closed
@nextcloud-bot nextcloud-bot mentioned this pull request Oct 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@juliushaertl juliushaertl juliushaertl approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@MariusBluem MariusBluem Awaiting requested review from MariusBluem

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews design Design, UI, UX, etc. enhancement feature: users and groups papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @jancborchardt @juliushaertl