Added 7 and 30 day values to "Active Users" stats graph #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhil1508
commented
Jan 11, 2021
•
akhil1508
commented
- Added 7 and 30 day values to the "Active users" stats graph (returned through "lib/SessionStatistics.php" and used in frontend in "js/script.js)
- Modified unit tests accordingly to test that new values are correctly returned
- Package "nextcloud/coding-standard" updated to "^0.4.0" from "^0.3.0"(PHPLint refuses to install correctly with 0.3.0 in the checks otherwise)
akhil1508
force-pushed
the
frontend_and_test_fixes
branch
from
de92f15 to
3c9c9b6
Compare
Signed-off-by: Matthew Wener <mwener115@gmail.com> Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: Matthew Wener <mwener115@gmail.com> Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: Matthew Wener <mwener115@gmail.com> Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: Joas Schilling <coding@schilljs.com> Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net> Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: Joas Schilling <coding@schilljs.com> Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
akhil1508
force-pushed
the
frontend_and_test_fixes
branch
from
3c9c9b6 to
1575062
Compare
akhil1508
changed the title
|
Ping |
|
The performance is already pretty bad on large instances. Most likely due share statistics but better safe than sorry. |
|
On our instance, the |
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
This was referenced Sep 20, 2022
|
Needs a major overhaul after #420 Want to have a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.