Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mobile view #397

Closed
wants to merge 2 commits into from
Closed

Fix mobile view #397

wants to merge 2 commits into from

Conversation

Dennis1993
Copy link
Contributor

Fix for #385

Before:
image

After:
image

Signed-off-by: Dennis1993 Dennis1993@users.noreply.github.com

Fix mobile view

Signed-off-by: Dennis1993 <Dennis1993@users.noreply.github.com>
Fix mobile view

Signed-off-by: Dennis1993 <Dennis1993@users.noreply.github.com>
@szaimen
Copy link
Contributor

szaimen commented Sep 12, 2022

Thanks! Though I fear it is still not working correctly:

click here

image

Tested with
docker run -it \
-p 8444:443 \
-e TRUSTED_DOMAIN=10.6.0.1 \
-e SERVERINFO_BRANCH=Dennis1993-patch-3 \
-v /:/host/ \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

@Dennis1993
Copy link
Contributor Author

Thank you!
Why is it not working?! :(
On my second testserver it is working too. I don't understand it.

image

@szaimen
Copy link
Contributor

szaimen commented Sep 12, 2022

Why is it not working?! :(
On my second testserver it is working too. I don't understand it.

did you test with multiple connected drives or only with one?

@Dennis1993
Copy link
Contributor Author

Both. My testserver A has only one disk and the second testserver has two drives. All other boxes are misaligned without this patch. If I use this patch, all boxed are correct aligned in mobile view.

@szaimen
Copy link
Contributor

szaimen commented Sep 12, 2022

I just tried again and recorded a video for you:

2022-09-12-161941.mp4

@Dennis1993 Dennis1993 requested a review from Valdnet September 17, 2022 12:34
@kesselb
Copy link
Collaborator

kesselb commented Nov 1, 2023

Thank you for the pull request 👍

I am closing it due to the lack of activity. If you have the time to continue, please make a new one.

@kesselb kesselb closed this Nov 1, 2023
@kesselb kesselb deleted the Dennis1993-patch-3 branch June 10, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants