Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(active users): add more active user statistics intervals and improve presentation #691

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

tcitworld
Copy link
Member

Adds:

  • last 7 days
  • last 1 month
  • last 3 months
  • last 6 months
  • last year

to the API endpoint.

This view will certainly get converted to Vue at some point (and with proper CSS variables), but it felt like a nice improvement (and to use the new metrics).

Before

Screenshot 2024-10-04 at 16-03-15 Système - Paramètres d'administration - Mon petit nuage

After

Full width

Screenshot 2024-10-04 at 16-00-56 System - Administration settings - Nextcloud

Tablet

Screenshot 2024-10-04 at 16-02-50 System - Administration settings - Nextcloud

Large Mobile

Screenshot 2024-10-04 at 16-01-45 System - Administration settings - Nextcloud

Small Mobile

Screenshot 2024-10-04 at 16-02-07 System - Administration settings - Nextcloud

@tcitworld tcitworld force-pushed the add-more-session-statistics-interval branch 2 times, most recently from bfbf606 to fab97cb Compare October 4, 2024 14:25
@nickvergessen nickvergessen removed their request for review October 4, 2024 14:45
@nickvergessen

This comment was marked as resolved.

@tcitworld tcitworld force-pushed the add-more-session-statistics-interval branch 2 times, most recently from b8ec66b to 87c8d58 Compare October 4, 2024 15:08
@joshtrichards joshtrichards added this to the Nextcloud 31 milestone Oct 4, 2024
templates/settings-admin.php Outdated Show resolved Hide resolved
templates/settings-admin.php Outdated Show resolved Hide resolved
templates/settings-admin.php Outdated Show resolved Hide resolved
templates/settings-admin.php Outdated Show resolved Hide resolved
templates/settings-admin.php Outdated Show resolved Hide resolved
@joshtrichards
Copy link
Member

A nice improvement, btw.

@joshtrichards
Copy link
Member

Just noticed this drops the 5 minute stat from the UI. Was that intentional?

@tcitworld
Copy link
Member Author

Just noticed this drops the 5 minute stat from the UI. Was that intentional?

I made the choice to not have too many statistics displayed in the UI, and I think it made more sense between 5 minutes and one hour to keep the second one.

@provokateurin provokateurin removed their request for review October 6, 2024 12:44
@kesselb
Copy link
Collaborator

kesselb commented Oct 10, 2024

image

I think the "last x" version is nicer.
The headline is active users and therefore the context should be clear ;)

@kesselb
Copy link
Collaborator

kesselb commented Oct 10, 2024

Thank you, nice enhancement 👍

@tcitworld tcitworld force-pushed the add-more-session-statistics-interval branch from 87c8d58 to 1e87ff7 Compare October 11, 2024 09:06
@tcitworld
Copy link
Member Author

I think the "last x" version is nicer.

Changed to this.

@tcitworld tcitworld force-pushed the add-more-session-statistics-interval branch from 1e87ff7 to aad51fe Compare October 11, 2024 09:08
@tcitworld tcitworld requested review from joshtrichards and kesselb and removed request for kesselb October 14, 2024 08:15
…rove presentation

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld force-pushed the add-more-session-statistics-interval branch from aad51fe to 0342a3c Compare October 14, 2024 14:01
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks really good!

Separate issue probably, but the icon of the heading is misaligned?

@kesselb kesselb merged commit b73a6ce into master Oct 14, 2024
36 checks passed
@kesselb kesselb deleted the add-more-session-statistics-interval branch October 14, 2024 16:34
@kesselb
Copy link
Collaborator

kesselb commented Oct 14, 2024

/backport to stable30

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants