Visual fixes and improvements #711
Conversation
Malex14
force-pushed
the
visual-fixes-and-improvements
branch
2 times, most recently
from
cfb0ada to
54d3785
Compare
|
I just rebased the pr on top of the current master branch |
|
Hello @kesselb, since you reviewed other PRs in the past, can you (or maybe someone else) please take a look at this PR? |
|
Hi, Thank you so much for your pull request—it’s much appreciated! Could you please update the implementation of Linux.getCpuCount to use /proc/cpuinfo, similar to how we handle it in Linux.getCpuName? I’d like to avoid executing shell commands where possible to keep things consistent and efficient. Let me know if you have any questions or need help with this! |
Signed-off-by: Malex14 <39774812+Malex14@users.noreply.github.com>
Signed-off-by: Malex14 <39774812+Malex14@users.noreply.github.com>
Changes in detail: - show load in percent - pined chart y max to 100% - added units to chart y-Axis - added small (by default) blue box to CPU load legend (like the one that was in the RAM legend) - added hover text to the "Load average: XX.X % (X.XX) last minute" that displays the load averages for 1, 5 and 15 minutes - added tooltip to both charts that display the cpu load / ram usage at the time where the cursor hovers. Signed-off-by: Malex14 <39774812+Malex14@users.noreply.github.com>
…commented out `@media` css rules, removed remains from when the css-file was scss Signed-off-by: Malex14 <39774812+Malex14@users.noreply.github.com>
Signed-off-by: Malex14 <39774812+Malex14@users.noreply.github.com>
Malex14
force-pushed
the
visual-fixes-and-improvements
branch
from
54d3785 to
1d234f3
Compare
Signed-off-by: Malex14 <39774812+Malex14@users.noreply.github.com>
Malex14
force-pushed
the
visual-fixes-and-improvements
branch
from
1d234f3 to
c04c3a5
Compare
|
Thank you for the quick response. I've changed the function as you asked. |
Signed-off-by: Malex14 <39774812+Malex14@users.noreply.github.com>
|
Linked two Issues this likely closes. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
| $numCpu = -1; | ||
|
|
||
| try { | ||
| $numCpu = intval($this->executeCommand('sysctl -n hw.ncpu')); //TODO: this should be tested if it actually works on FreeBSD |
There was a problem hiding this comment.
That yields the expected result for my cpu.
There was a problem hiding this comment.
ok 👍 , then I will remove the comment
|
/backport to stable30 |
|
should I rebase the commits on top of master again? |
This PR fixes a lot of small CSS-Issues and improves the cpu and memory charts.
Charts
I've updated the chart library to the latest version and added a tooltip that displays the cpu / ram usage at the point of time where the cursor hovers over the chart. Additionally the cpu chart and legend show the usage now in percent (instead of 0 to cpu count) and has its y max fixed at 100%. I've also added a hover text to the cpu legend that displays the averages of the past 1, 5 and 15 minutes. Also the y-Axis is now readable in dark mode:
Click to show screenshots
Original:
Improved:
Overflowing Boxes
To fix the mobile overflows, I mostly just reenabled the commented out
@mediarules. But a few other changes had to be made too:Click to show screenshots
Original:
Improved:
Overlapping Text
Lastly there was some overlapping text in the "External monitoring tool" section:
Click to show screenshots
Original:
Improved: