Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing integration tests are failing #1336

Closed
nickvergessen opened this issue Dec 5, 2018 · 2 comments
Closed

Sharing integration tests are failing #1336

nickvergessen opened this issue Dec 5, 2018 · 2 comments
Labels
1. to develop bug feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings
Milestone
5.0.0

Comments

@nickvergessen
Copy link
Member

This broke with: nextcloud/server#12544

Recipient should not be able to edit shares.
But we do exactly that in our tests 🙈
@nickvergessen
Copy link
Member Author

Something for after beta @danxuliu

@nickvergessen nickvergessen added 1. to develop bug feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings labels Dec 5, 2018
@nickvergessen nickvergessen added this to the 💚 Next Major milestone Dec 5, 2018
@nickvergessen
Copy link
Member Author

spreed/tests/integration/features/sharing/update.feature

Lines 508 to 510 in e273ac4

When user "participant2" updates last share with
| permissions | 1 |
| expireDate | +3 days |
was actually never intended and was fixed by nextcloud/server#12544

@danxuliu danxuliu mentioned this issue Dec 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop bug feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
1 participant
@nickvergessen