Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle permission in update of share better #12544

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Nov 20, 2018

Hardening to prevent potential issues.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
Copy link
Member Author

rullzer commented Nov 20, 2018

/backport to stable14

@rullzer
Copy link
Member Author

rullzer commented Nov 20, 2018

/backport to stable13

@rullzer
Copy link
Member Author

rullzer commented Nov 20, 2018

/backport to stable12

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 20, 2018
@rullzer rullzer merged commit 1bf742c into master Nov 20, 2018
@rullzer rullzer deleted the fix/better_update_share_handling branch November 20, 2018 15:19
@backportbot-nextcloud
Copy link

The backport to stable14 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable13 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable12 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: sharing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants