Merge pull request #12544 from nextcloud/fix/better_update_share_hand…

…ling Handle permission in update of share better
nextcloud · Nov 20, 2018 · 1bf742c · 1bf742c
2 parents e73bfd5 + a343a60
commit 1bf742c
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/apps/files_sharing/lib/Controller/ShareAPIController.php b/apps/files_sharing/lib/Controller/ShareAPIController.php
@@ -808,6 +808,10 @@ public function updateShare(
 			throw new OCSNotFoundException($this->l->t('Wrong share ID, share doesn\'t exist'));
 		}
 
+		if ($share->getShareOwner() !== $this->currentUser && $share->getSharedBy() !== $this->currentUser) {
+			throw new OCSForbiddenException('You are not allowed to edit incomming shares');
+		}
+
 		if ($permissions === null &&
 			$password === null &&
 			$sendPasswordByTalk === null &&