Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public vs private rooms - Allow users to freely join a room #1763

Closed
schiessle opened this issue Apr 30, 2019 · 15 comments · Fixed by #4706
Closed

Public vs private rooms - Allow users to freely join a room #1763

schiessle opened this issue Apr 30, 2019 · 15 comments · Fixed by #4706
Assignees
Labels
1. to develop enhancement feature: api 🛠️ OCS API for conversations, chats and participants

Comments

@schiessle
Copy link
Member

I had this idea while using Talk. With "public rooms" I don't mean rooms I share by a public link. I want to make a different distinction here.

We have two types of rooms at the moment:

  1. 1-1 chat rooms
  2. group chat rooms

Both have one in common, you have to invite your chat partner(s). Think about a larger setup of an organization, your sports club, etc. Every time someone new joins your organization you have to add them to the relevant rooms manually. If someone leaves you have to remove them again. A lot of manual work with a high risk to make mistakes.

That's where my idea of "private vs public" rooms starts.

I would define private rooms as rooms where the users in the room decide who can join and who not, by inviting users, sending links around, etc. Basically what we have now.

Public rooms would be rooms someone creates and which are then open to join for everyone. Users could search for public rooms on the left hand sidebar like they search for users and groups today. They can join any of this rooms and participate in the discussion. A bit like I can join a IRC server, look around which channels exists and join the one I'm interested in.

Opinions?

@schiessle schiessle changed the title Idea: Public vs closed rooms Idea: Public vs rivate rooms Apr 30, 2019
@schiessle schiessle changed the title Idea: Public vs rivate rooms Idea: Public vs private rooms Apr 30, 2019
@nickvergessen nickvergessen added feature: api 🛠️ OCS API for conversations, chats and participants and removed 0. Needs triage labels Apr 30, 2019
@nickvergessen nickvergessen added this to the 💔 Backlog milestone Apr 30, 2019
@sunjam
Copy link

sunjam commented May 21, 2019

Circles integration is a possibility for helping add this functionality since you can create your own "groups" of users as public, private, closed, or secret circles. Once conversations can be started with a circle, it will be possible to start group discussions.

@nickvergessen nickvergessen changed the title Idea: Public vs private rooms Public vs private rooms Jun 25, 2019
@nickvergessen nickvergessen changed the title Public vs private rooms Public vs private rooms - Allow users to freely join a room Jun 25, 2019
@jancborchardt
Copy link
Member

Totally agree! This could also be useful for guests, where you then have the AppNavigation shown with all the conversations specifically set to "Public". In our case all the public team channels.

@robertfromont
Copy link

I'm looking to replace Slack with NextCloud Talk, and this is the main thing I would need to achieve that; for already-registered users, a set of Conversations they can join without needing a specific invitation.
So that's a 👍 from me!

@jcastang
Copy link

Same thing for me !
Being able to join a room without invitation is a must-have.

@PVince81
Copy link
Member

PVince81 commented Nov 3, 2020

  • All the rooms regardless of type (except file rooms, 1-1 and video verification) receive a new listable flags with an extra checkbox in the room settings:

    • listable for regular users
    • listable for guest users (from guest app)
  • any guest (public link access) cannot find it for now: we have no UI

  • any guest from the guest app can see all the listed rooms flagged as such

  • any logged in user can find it (for private rooms)

  • "listed" rooms appear below the joined rooms (order is: favorites, joined, then listed rooms)

  • make it possible to set/unset the listable property after creation?

  • where do guests see that list?

  • if logic already exists: add extra step for joining

    • able to "lurk" first and have a button to join (aka self-join)
    • auto-join after typing

@PVince81
Copy link
Member

PVince81 commented Nov 3, 2020

@PVince81
Copy link
Member

PVince81 commented Nov 3, 2020

  • only display listed rooms in the left panel:
    • when searched in top left room search
    • click plus button, ability to join a room instead of creating
    • because otherwise: too crowded and performance impact

@PVince81
Copy link
Member

  • do we want a system message to be posted "actor_x made this room listable for Y" ? (like for when locking/unlocking)

@nickvergessen
Copy link
Member

a system message yeah, but what is for Y?

@PVince81
Copy link
Member

  • "actor_x made this room listable for all"
  • "actor_x made this room listable for guest users"

since we planned for both options ^

@nickvergessen
Copy link
Member

The room type GROUP vs. PUBLIC room type controls that part? Not sure we need to repeat this. We don't mention it on any other message (lobby, read-only, ...) either.

@PVince81
Copy link
Member

PVince81 commented Dec 1, 2020

hmmm, from my understanding from last time I think we said almost all room types except 1-1 and files, which would give 4 cases:

  • group room (non-public):
    • listable for regular users
    • listable for guest users (from guest app)
  • public room:
    • listable for regular users
    • listable for guest users (from guest app)

so if as an admin+moderator in a group room I click "listable for regular users", the message "You made the room listable for regular users", then I click "listable for guest users", another message "You made the room listable for guests". So now everyone can see it.

or were the listable modes intended to be exclusive (radio buttons, not checkboxes) ?

@PVince81
Copy link
Member

PVince81 commented Dec 1, 2020

draft PR here: #4706

@PVince81
Copy link
Member

PVince81 commented Dec 1, 2020

I'm having doubts about the "separate flags" approach. Maybe it doesn't make sense to allow guests to list rooms without also allowing regular users ?

@nickvergessen
Copy link
Member

yeah, should work like the "start call" option:

  • regular users
  • logged in users
  • everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop enhancement feature: api 🛠️ OCS API for conversations, chats and participants
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants