Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict posting to moderators #4487

Closed
wants to merge 2 commits into from
Closed

Restrict posting to moderators #4487

wants to merge 2 commits into from

Conversation

jakobroehrl
Copy link
Contributor

@jakobroehrl jakobroehrl commented Oct 29, 2020

Fix #3886

grafik

Todo:

  • set archived state in localstore
  • hide archived rooms
  • show archived room (filter icon)
  • save state in database
  • sort archived rooms to the end of list
  • nice icon, where to place the filter icon?

Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
@jakobroehrl jakobroehrl self-assigned this Oct 29, 2020
@jakobroehrl jakobroehrl changed the title save archiv state in local store Support for room archival Oct 29, 2020
@jakobroehrl jakobroehrl linked an issue Oct 29, 2020 that may be closed by this pull request
@nickvergessen
Copy link
Member

nickvergessen commented Oct 29, 2020

I would just sort archived rooms to the end (so invert favorites basically) or even not load them and instead have a filter icon where you can toggle them in and out (need something similar for for the "listed" rooms anyway #1763 )

@@ -82,6 +82,11 @@

<ActionSeparator />

<ActionButton v-if="canLeaveConversation"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong permission check

:icon="iconArchive"
@click.prevent.exact="toggleArchiveConversation">
{{ labelArchive }}
</ActionButton>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a purely moderator option it should go into the moderator menu?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's only a moderator option.
Everybody should archiv a room to have a cleaner room list.
But wait, this is not possible with this setup. This needs to be done on a user basis.
So maybe I don't understand the aim here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A per user archiving is way over the top from my pov.

@jakobroehrl jakobroehrl added this to the 💚 Next Major (21) milestone Oct 30, 2020
Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
@nickvergessen
Copy link
Member

Master is 22 now

@nickvergessen nickvergessen changed the title Support for room archival Restrict posting to moderators Mar 2, 2021
@jakobroehrl jakobroehrl closed this Mar 2, 2021
@nickvergessen
Copy link
Member

New attempt in #5259

@nickvergessen nickvergessen deleted the enh/archiveConv branch March 2, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛂 Chat permission Support for room archival
2 participants