Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access denied to public room links, when app is limited to a group #201

Closed
Bugsbane opened this issue Dec 30, 2016 · 3 comments
Closed

Access denied to public room links, when app is limited to a group #201

Bugsbane opened this issue Dec 30, 2016 · 3 comments
Assignees
Labels
Milestone

Comments

@Bugsbane
Copy link
Member

I have most of my apps set to only show to the admin group, so my family isn't confused by seeing various random apps I'm tinkering with on my server. This includes the Spreed app which is set to be visible just to the admin group.

When I, as an admin, log in though and create a public room link, anyone clicking on that link gets shown a Nextcloud error page saying that they don't have permission to access this page.

On the one hand I understand, I mean I did say t limit Spreed to the admin group. On the other hand I, as an admin user with full access rights, chose to make a room available to the world and Spreed doesn't let me.

Is there any way we can make an exception, so public rooms can be made available by authorized group members?

@Bugsbane Bugsbane changed the title public room links fail when app is group limited Access denied to public room links, when app is limited to a group Dec 30, 2016
@nickvergessen
Copy link
Member

nickvergessen commented Jan 4, 2017

No, because when the app is only available to some users, it is not even loaded for others.
That is nothing in control of the spreed app.

Fix is to remove the restriction.

I guess we should make use of prevent_group_restriction Otherwise you can call people and neither you nor them ever notice that it doesn't work.

@Bugsbane
Copy link
Member Author

Bugsbane commented Jan 5, 2017

Rather than completely removing people's ability to make Spreed available to specific groups, I suggest we only remove the ability to create "public" (cough) links when the app is group limited.

That way, we remove the confusion and links going to error pages, but retain people's ability to keep the app available to specific groups.

@nickvergessen
Copy link
Member

Well but you can still try to call people, which don't have access to the app. And you have no way of knowing this.
That's why I think it's okay to remove the restriction.

marcoambrosini pushed a commit that referenced this issue Oct 9, 2019
…atepicker-2.7.0

Bump vue2-datepicker from 2.6.4 to 2.7.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants