Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destroy room if empty #4

Closed
LukasReschke opened this issue Sep 19, 2016 · 4 comments
Closed

Destroy room if empty #4

LukasReschke opened this issue Sep 19, 2016 · 4 comments
Milestone
1.0.0

Comments

@LukasReschke
Copy link
Member

No description provided.

@LukasReschke LukasReschke added this to the 1.0.0 milestone Sep 19, 2016
@fancycode
Copy link
Member

Empty rooms should only be removed if they have not been used for some time (configurable/fixed?), otherwise you can't reload your browser if you are the only participant in a room as the room could get deleted while reloading.

@jancborchardt
Copy link
Member

We should delete it only after some time, but not configurable. Say when it’s not used for 12 hrs, delete it.

@ChristophWurst
Copy link
Member

Hm, the public interface OCP\BackgroundJob\IJob is 💩 to implement and I cannot extend the convenient abstraction OC\BackgroundJob\Job because it's private API and we're using the app code checker.

@LukasReschke any idea how to solve this?

@nickvergessen
Copy link
Member

Since leaving a room is a intentional action now, this is handled.
One2One rooms are also deleted as soon as one person intentionally leaves the room:
#81

@nickvergessen nickvergessen mentioned this issue Nov 14, 2016
Merged
@tiotrom tiotrom mentioned this issue Sep 12, 2019
Closed
nickvergessen pushed a commit that referenced this issue Jan 27, 2020
@oozman
Enable last edit (#4)
bc8d858 
* Implement /isActorBelongTo endpoint.
* Check first if actor is allowed to edit last message.
@EliterScripts EliterScripts mentioned this issue Mar 28, 2020
Closed
@netzgestaltung netzgestaltung mentioned this issue Oct 11, 2020
Closed
@grandiego grandiego mentioned this issue Feb 16, 2022
Closed
@Stupidscript Stupidscript mentioned this issue Aug 23, 2024
Closed
miaulalala added a commit that referenced this issue Nov 27, 2024
@miaulalala
# This is a combination of 9 commits.
cf54d5d 
# This is the 1st commit message:

feat: add option to force passwords in public conversations

Signed-off-by: Anna Larch <anna@nextcloud.com>

# The commit message #2 will be skipped:

# fixup! feat: add option to force passwords in public conversations

# The commit message #3 will be skipped:

# fixup! feat: add option to force passwords in public conversations

# The commit message #4 will be skipped:

# fixup! feat: add option to force passwords in public conversations

# The commit message #5 will be skipped:

# fixup! fixup! feat: add option to force passwords in public conversations

# The commit message #6 will be skipped:

# fixup! fixup! feat: add option to force passwords in public conversations

# The commit message #7 will be skipped:

# fixup! feat: add option to force passwords in public conversations

# The commit message #8 will be skipped:

# fixup! feat: add option to force passwords in public conversations

# The commit message #9 will be skipped:

# fixup! feat: add option to force passwords in public conversations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
5 participants
@nickvergessen @fancycode @LukasReschke @jancborchardt @ChristophWurst