Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reparent viewer in fullscreen mode #6882

Open
1 task
danxuliu opened this issue Feb 8, 2022 · 3 comments
Open
1 task

Reparent viewer in fullscreen mode #6882

danxuliu opened this issue Feb 8, 2022 · 3 comments
Labels
1. to develop bug feature: frontend 🖌️ "Web UI" client technical debt
Milestone
💔 Backlog

Comments

@danxuliu
Copy link
Member

danxuliu commented Feb 8, 2022 •
edited by nickvergessen
Loading

By default the viewer is a sibling of the fullscreen element, so it is not visible when in fullscreen mode. In #6879 the viewer is reparented shortly after opening it in fullscreen mode, but this hack should be removed once it is possible to specify the parent element of the viewer.
@nickvergessen nickvergessen added this to the 💔 Backlog milestone Feb 8, 2022
@Emeka-Ugbanu-hub
Copy link

I would love to help with this

@nickvergessen
Copy link
Member

See the linked issue nextcloud/viewer#995
It's the starting point and has lots of links to the problematic places

@Emeka-Ugbanu-hub
Copy link

have seen them which one do you need help with so I can have a go at it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop bug feature: frontend 🖌️ "Web UI" client technical debt
Projects
None yet
Milestone
💔 Backlog
Development

No branches or pull requests
3 participants
@nickvergessen @danxuliu @Emeka-Ugbanu-hub