Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make possible to specify the container element for the viewer #995

Open
danxuliu opened this issue Aug 26, 2021 · 2 comments
Open

Make possible to specify the container element for the viewer #995

danxuliu opened this issue Aug 26, 2021 · 2 comments
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working

Comments

@danxuliu
Copy link
Member

The viewer does not set nor allows to set a specific element as the container of the modal dialog, and by default modal dialogs use the body element. However, in some cases the viewer needs to be appended to a different element (for example, if a sub-element is shown in fullscreen mode, like done in Talk), as otherwise it would not be visible.

How to test

  • Open a conversation in Talk
  • Share a picture in the conversation
  • Switch to full screen mode
  • Try to open the viewer for the picture

Expected result

The viewer is shown.

Actual result

The viewer is not shown (and neither its overlay).

@ShGKme
Copy link
Contributor

ShGKme commented May 2, 2023

Would it be fine to add a container prop, to pass it to the NcModal's container?

@skjnldsv
Copy link
Member

skjnldsv commented May 2, 2023

At this point I would like to refactor the Viewer and make it a package alongside this app 🙈
So people can import and call the Viewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants