-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make possible to specify the container element for the viewer #995
Labels
Comments
danxuliu
added
bug
Something isn't working
1. to develop
Accepted and waiting to be taken care of
labels
Aug 26, 2021
This was referenced Feb 7, 2022
Would it be fine to add a |
At this point I would like to refactor the Viewer and make it a package alongside this app 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
The viewer does not set nor allows to set a specific element as the container of the modal dialog, and by default modal dialogs use the body element. However, in some cases the viewer needs to be appended to a different element (for example, if a sub-element is shown in fullscreen mode, like done in Talk), as otherwise it would not be visible.
How to test
Expected result
The viewer is shown.
Actual result
The viewer is not shown (and neither its overlay).
The text was updated successfully, but these errors were encountered: