Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chatting as guest calls "GuestManager::updateName" for every message #865

Closed
fancycode opened this issue May 8, 2018 · 0 comments
Closed
Assignees
Labels
bug feature: chat 💬 Chat and system messages

Comments

@fancycode
Copy link
Member

Steps to reproduce

  1. Connect as guest user to a room.
  2. Send chat messages.

Expected behaviour

The name of the user should not be updated if it didn't change.

Actual behaviour

GuestController::updateName is called for every message:

$this->guestManager->updateName($room, $sessionId, $actorDisplayName);

This should either only be done if the name has changed, or updateName should detect the same name internally and perform a no-op in such cases.

Updating the name causes unnecessary database updates and unnecessarily reloads of the participant list by all clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature: chat 💬 Chat and system messages
Projects
None yet
Development

No branches or pull requests

2 participants