Stop refreshing participant list when a guest is chatting #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
3. to review
bug
feature: chat 💬
fancycode
reviewed
May 8, 2018
| ->set('display_name', $query->createNamedParameter($displayName)) | ||
| ->where($query->expr()->eq('session_hash', $query->createNamedParameter($sessionHash))); | ||
| $query->execute(); | ||
| $dispatchEvent = true; |
There was a problem hiding this comment.
right, changed the logic of the code and broke this.
lib/GuestManager.php
Outdated
| $dispatchEvent = true; | ||
| } | ||
| } catch (ParticipantNotFoundException $e) { | ||
| $this->connection->insertIfNotExist('*PREFIX*talk_guests', [ |
There was a problem hiding this comment.
IMHO inserting an initial name should also dispatch an event.
There was a problem hiding this comment.
It does, because of the $dispatchEvent = true;
Signed-off-by: Joas Schilling <coding@schilljs.com>
fancycode
reviewed
May 8, 2018
lib/GuestManager.php
Outdated
|
|
||
| try { | ||
| $oldName = $this->getNameBySessionHash($sessionHash); | ||
| $dispatchEvent = $oldName !== $displayName; |
There was a problem hiding this comment.
Better, though I would rather write it like this to save the redundant comparison:
if ($oldName !== $displayName) {
...
} else {
$dispatchEvent = false;
}But that's just my personal taste 😉
Ivansss
approved these changes
May 9, 2018
Ivansss
deleted the
bugfix/865/stop-refreshing-participant-list-when-a-guest-is-chatting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #865