Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require a global backened secret when allowall is not set #10022

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

SystemKeeper
Copy link
Contributor

☑️ Resolves

🏁 Checklist

@SystemKeeper SystemKeeper requested a review from danxuliu July 19, 2023 18:31
@SystemKeeper SystemKeeper self-assigned this Jul 19, 2023
@SystemKeeper SystemKeeper added 3. to review feature: recordings ⏺️ Including the recording server labels Jul 19, 2023
@SystemKeeper SystemKeeper added this to the 💜 Next Major (28) milestone Jul 19, 2023
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer something like if self._configParser.get('backend', 'allowall', fallback=None) == 'true' instead for consistency with other boolean options (as otherwise this would accept 1/0, yes/no... while the other would only accept true/false (ok, strictly speaking, true /anything else :-P ).

Alternatively _getBackendValue could be extended with _getBackendBooleanValue and _getBackendIntValue... but checking against 'true' is easier ;-)

Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper SystemKeeper force-pushed the fix/9580/global-recording-secret-requirement branch from b1c9048 to a57e67a Compare July 20, 2023 14:28
@SystemKeeper
Copy link
Contributor Author

I would prefer something like if self._configParser.get('backend', 'allowall', fallback=None) == 'true'

Sure - fine by me :-) PR updated.

@SystemKeeper SystemKeeper requested a review from danxuliu July 20, 2023 14:29
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global secret for recording server backend should not be needed
2 participants