Add support for backend favorites #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mario
force-pushed
the
add-room-favourite-support
branch
from
167dcbb to
87826fe
Compare
|
Would be nice, if you create tickets to describe what you are doing, instead of trying to blindly code php |
|
@nickvergessen absolutely. But there's already a ticket for this? |
|
(I'm learning :D) |
Signed-off-by: Mario Danic <mario@lovelyhq.com>
nickvergessen
force-pushed
the
add-room-favourite-support
branch
from
87826fe to
48665e9
Compare
|
Fixed the php side and added support to the web ui I guess tests will fail now, will have a look on my next run. |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
add-room-favourite-support
branch
from
48665e9 to
3dce453
Compare
nickvergessen
added
enhancement
feature: api 🛠️
|
@nickvergessen just one thing: why do we need it in capabilities? |
|
So the clients know when its there? |
|
They already know because if room doesnt contain favorite object, they just
wont show it.
…On Fri, 13 Jul 2018 at 18:07, Joas Schilling ***@***.***> wrote:
So the clients know when its there?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1025 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAWsq0mnCipH2Em1Zwqa0OpxOcsqfewks5uGMWxgaJpZM4VGA0s>
.
|
1 task
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Ivansss
approved these changes
Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend support for #998.
Dunno if it works, coding blindly. Initial review would be welcome.
Signed-off-by: Mario Danic mario@lovelyhq.com