Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guest moderators #1075

Closed
wants to merge 4 commits into from
Closed

Guest moderators #1075

wants to merge 4 commits into from

Conversation

Peterede
Copy link
Contributor

Changes to allow moderator status to be assigned to guests in a meeting. The role of the guest can be set from a hook using the password to identify the user.

@Peterede Peterede requested a review from fancycode July 24, 2018 23:11
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be left after #1078 is:
Assign the type based on the password

if ($targetParticipant->getParticipantType() !== Participant::GUEST) {
return new DataResponse([], Http::STATUS_FORBIDDEN);
}
//if ($targetParticipant->getParticipantType() !== Participant::GUEST) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I implemented guest moderators in #1078 so this should not be needed anymore.

Copy link
Member

@fancycode fancycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Peterede could you please rebase this on #1078 to only have the additional changes in this PR?

@nickvergessen nickvergessen added this to the Next Major milestone Jul 30, 2018
@Peterede Peterede closed this Oct 10, 2018
@nickvergessen nickvergessen deleted the guest-moderators branch December 11, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants