Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(federation): Implement notifications for mentions, reply and full #11691

Merged
merged 5 commits into from
Mar 6, 2024
Merged

feat(federation): Implement notifications for mentions, reply and full #11691

merged 5 commits into from
Mar 6, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 29, 2024 •
edited
Loading

🛠️ API Checklist

🚧 Tasks

  • Notifications when being mentioned
  • Notification when being replied to
  • Notification when being full subscribed

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen marked this pull request as draft February 29, 2024 19:32
@nickvergessen nickvergessen added 2. developing enhancement feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐 labels Feb 29, 2024
@nickvergessen nickvergessen added this to the 💞 Next Major (29) milestone Feb 29, 2024
@nickvergessen nickvergessen self-assigned this Feb 29, 2024
Base automatically changed from bugfix/noid/fix-psalm-and-phpunit to main February 29, 2024 20:14
@nickvergessen
feat(federation): Add columns to save the creation datetime and meta …
f495741 
…data

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(events): Expose the parent comment in events
d4c11cc 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen marked this pull request as ready for review March 6, 2024 12:21
@nickvergessen nickvergessen force-pushed the feat/11272/notifications branch 2 times, most recently from f3804f2 to 0f2c472 Compare March 6, 2024 14:10
@nickvergessen nickvergessen changed the title feat(federation): Notifications feat(federation): Implement notifications for mentions, reply and full Mar 6, 2024
Antreesy
Antreesy approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested (apart from 'full' mode)

@nickvergessen
fix(API): Add constants for known comments metadata
1a26108 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
feat(federation): Allow to convert a single type and id
578b1d5 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
feat(federation): Implement notifications for mentions, reply and full
cdc988c 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit 9e51949 into main Mar 6, 2024
66 checks passed
@nickvergessen nickvergessen deleted the feat/11272/notifications branch March 6, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages feature: federation 🌐
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @Antreesy