Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ConversationIcon): force light background color for conversation … #11769

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Mar 11, 2024

…type when using light theme

☑️ Resolves

It is aligned with used theme.

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Code review

🏁 Checklist

@DorraJaouad DorraJaouad self-assigned this Mar 11, 2024
@DorraJaouad DorraJaouad added this to the 💞 Next Beta (29) milestone Mar 11, 2024
@Antreesy
Copy link
Contributor

That's a problem of TopBar switching manually to dark mode in call, so I believe, that should be handled in Topbar itself. Here's my attempt to do ti:

+	<div class="top-bar" :style="topBarStyle" :data-theme-dark="isInCall">
 
+		topBarStyle() {
+			return {
+				'--original-color-main-background': window.getComputedStyle(document.body).getPropertyValue('--color-main-background')
+			}
+		},
+

+		:deep(.conversation-icon__type) {
+			border-color: var(--original-color-main-background) !important;
+			background-color: var(--original-color-main-background) !important;
+		}
 	}

…type when using light theme

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the fix/noid/conversation-type-in-call branch from cb03760 to 99c0cfe Compare March 11, 2024 13:22
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that important is needed, but let's keep it just in case

@DorraJaouad
Copy link
Contributor Author

Not sure that important is needed, but let's keep it just in case

Might be needed because colors are already set for the element and parent's style can be skipped.

@DorraJaouad DorraJaouad merged commit d065a28 into main Mar 11, 2024
46 checks passed
@DorraJaouad DorraJaouad deleted the fix/noid/conversation-type-in-call branch March 11, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants