Add admin setting to specify a TURN server and a shared secret #120
Conversation
|
|
||
| $time = $timeFactory->getTime(); | ||
|
|
||
| $string = sprintf('%d:%s', $time + 3600, $sessionId); |
There was a problem hiding this comment.
The TTL should probably a parameter and must also be returned to the user, so it can refresh the credentials before they expire (which can happen if the user is connected longer than the TTL).
There was a problem hiding this comment.
How is this returned?
There was a problem hiding this comment.
Unfortunately I don't know how SimpleWebRTC handles this.
For spreed-webrtc we have a field in our signalling protocol to include the (optional) TTL for TURN credentials.
There was a problem hiding this comment.
According to the signalling server they just default to 24h: https://github.com/andyet/signalmaster/blob/e98d388a2107330948616661064cb329d2749314/sockets.js#L114
* then calculates the user credentials on the fly for 1 hour Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
force-pushed
the
turn-server-admin-setting
branch
from
7ffb59b to
17c4da6
Compare
|
@fancycode I changed it to 24h for now and we could tweak this later |
|
🙈 fine with me |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
force-pushed
the
turn-server-admin-setting
branch
from
31838dd to
32fe285
Compare
Current coverage is 11.14% (diff: 35.41%)@@ master #120 diff @@
=========================================
Files 13 13
Lines 713 754 +41
Methods 49 50 +1
Messages 0 0
Branches 0 0
=========================================
+ Hits 70 84 +14
- Misses 643 670 +27
Partials 0 0
|
cc @fancycode @LukasReschke