Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MediaSettings): sync preferences with devices direct selection #12189

Merged
merged 7 commits into from
Jun 10, 2024

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Apr 23, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
before-sticky After-sticky

🚧 Tasks

  • Do not show "Apply Settings" on changes that touch devices only.
  • Update preferences needs to be called @update:deviceId event. This will cover both media settings and Talk settings devices changes.
  • To move "check if preferences update is called at least once" to showModal(), because user may open and close media settings without any pref update and without reload. It makes more sense to also force it next time they open it.
  • Split audio and video preferences update

🏁 Checklist

@DorraJaouad DorraJaouad added 3. to review feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients feature: call 📹 Voice and video calls labels Apr 23, 2024
@DorraJaouad DorraJaouad added this to the 💙 Next Major (30) milestone Apr 23, 2024
@DorraJaouad DorraJaouad self-assigned this Apr 23, 2024
@DorraJaouad DorraJaouad force-pushed the fix/12185/devices-saving branch from 23e6361 to 7a4772c Compare April 23, 2024 13:37
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Let's wait for Daniel's input

src/components/MediaSettings/MediaSettings.vue Outdated Show resolved Hide resolved
src/utils/webrtc/MediaDevicesManager.js Outdated Show resolved Hide resolved
@DorraJaouad DorraJaouad force-pushed the fix/12185/devices-saving branch 2 times, most recently from 001af34 to 70f2279 Compare April 24, 2024 17:47
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not fond of the decision to open it only the first time, but with my comments that should match the issue description

src/components/MediaSettings/MediaSettings.vue Outdated Show resolved Hide resolved
@DorraJaouad DorraJaouad force-pushed the fix/12185/devices-saving branch from 70f2279 to 495218a Compare April 25, 2024 11:36
…ces are not set yet.

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
…show apply settings button to devices change

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
… be passed.

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the fix/12185/devices-saving branch from 495218a to 2bbe8f7 Compare June 10, 2024 15:11
@DorraJaouad
Copy link
Contributor Author

Rebased

@DorraJaouad DorraJaouad merged commit e84e910 into main Jun 10, 2024
46 checks passed
@DorraJaouad DorraJaouad deleted the fix/12185/devices-saving branch June 10, 2024 15:33
@DorraJaouad
Copy link
Contributor Author

/backport to stable29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review feature: call 📹 Voice and video calls feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients
Projects
Archived in project
2 participants