-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification levels #1230
Notification levels #1230
Conversation
oooo we are so excited! please make this happen for the major release, thank you! After this, we will consider the enterprise licensing |
f91030d
to
2a2e6d9
Compare
@jancborchardt currently we go for 3 options:
where/how should users be able to set this? In the Additionally, should we show something similar to the grey mute icon Whatapp and others are showing when a conversation is set to "never"? |
Thanks for your diligence @nickvergessen !! |
2a2e6d9
to
fca7851
Compare
Ready for review. I also think that the dropdown menu is the right place, since it also handles the favorite state, so it looks like the following screenshot for now: From IRC:
We can also go for other icons (I think they are fine, although a crossed-through speaker would be better for never) and/or a new layout (putting the icons in one row with hover title, or whatever) |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
fca7851
to
64e2625
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
Notification's text should change when someone writes in a group/public room. |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
done |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Looks great @nickvergessen! :) Also yes for the mute-icon like in Signal and WhatsApp. The default notification setting for every channel should be on @-mention initially. |
@jancborchardt people waited forever to get ALWAYS notifications in 1-to-1 conversations. Why take it away from them? |
Default remains the current behaviour:
|
Awesome
…On Tue, 9 Oct 2018, 15:09 Joas Schilling, ***@***.***> wrote:
Default remains the current behaviour:
- One2one: Always
- Others: Mention
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1230 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAWspn1g7G32O4ZDsdGojSqcvGmzCPJks5ujKAlgaJpZM4XCBZW>
.
|
Totally missed this – just for the record, when I said "for every channel" I meant "for every group channel". So the defaults @nickvergessen mentioned are 👍 |
First of all, thanks a lot to everyone here for your great work! We are introducing Talk at the moment in our organization and there have been several complaints with regard to the notification level (it actually took me a while to figure out the "notification if mentioned"-level, since this is not the default option I know from other messengers): Once again, thanks a lot for all your work! |
@errotu could you open a new issue with your request? :) Listing comparisons with how other messengers are doing it are very welcome too. |
@jancborchardt Thanks for the quick reply! I have now opened #2085. |
Fix #1099