Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(capabilities): Expose which capabilities should be considered lo… #12311

Merged
merged 2 commits into from
May 10, 2024
Merged

feat(capabilities): Expose which capabilities should be considered lo… #12311

merged 2 commits into from
May 10, 2024

Conversation

nickvergessen
Copy link
Member

…cal vs federated

☑️ Resolves

🛠️ API Checklist

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen
feat(capabilities): Expose which capabilities should be considered lo…
bf240be 
…cal vs federated

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the 💙 Next Major (30) milestone May 8, 2024
@nickvergessen nickvergessen self-assigned this May 8, 2024
@nickvergessen
Copy link
Member Author

/backport to stable29

SystemKeeper
SystemKeeper reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should also mark config => signaling => hello-v2-token-key as local for now?

docs/capabilities.md Show resolved Hide resolved
docs/capabilities.md Show resolved Hide resolved
Antreesy
Antreesy approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't break anything, and would be helpful for detecting local-only features on a frontend. Thanks!

@nickvergessen
fix(capabilities): Mark federation and signaling capabilities as local
fb8a73c 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

Added federation configs and signaling configs to it, as they are also both "local" at the moment

@nickvergessen nickvergessen merged commit f00d7a6 into main May 10, 2024
64 checks passed
@nickvergessen nickvergessen deleted the feat/noid/add-local-capabilities branch May 10, 2024 10:28
@backportbot backportbot bot mentioned this pull request May 10, 2024
Merged
2 tasks
@danxuliu danxuliu mentioned this pull request May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SystemKeeper SystemKeeper SystemKeeper approved these changes

@Antreesy Antreesy Antreesy approved these changes

@mahibi mahibi Awaiting requested review from mahibi

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug
Projects
None yet
Milestone
v20.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @SystemKeeper @Antreesy