Skip to content

refactor(plugins): add reusable requestRoomSelection util to run room selector#12356

Merged
ShGKme merged 2 commits intomainfrom
refactor/room-selector-app
May 15, 2024
Merged

refactor(plugins): add reusable requestRoomSelection util to run room selector#12356
ShGKme merged 2 commits intomainfrom
refactor/room-selector-app

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented May 15, 2024

☑️ Resolves

  • 4 plugins have almost copy/past implementation of room selection
  • Simplifies Vue 3 migration
  • 👀 Review by commit with hide whitespaces

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

No visual changes

🚧 Tasks

  • Get rid of unneeded IIFE
  • Add reusable util to mount RoomSelector and get the selected room

🏁 Checklist

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the refactor/room-selector-app branch from 4864f2d to 447ae13 Compare May 15, 2024 09:59
@ShGKme ShGKme changed the title refactor(integration): add reusable requestRoomSelection util to run room selector refactor(plugins): add reusable requestRoomSelection util to run room selector May 15, 2024
@ShGKme ShGKme requested review from Antreesy and DorraJaouad May 15, 2024 10:05
@ShGKme ShGKme self-assigned this May 15, 2024
@ShGKme ShGKme added this to the 💙 Next Major (30) milestone May 15, 2024
@ShGKme ShGKme force-pushed the refactor/room-selector-app branch from 447ae13 to ee916fa Compare May 15, 2024 10:06
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the refactor/room-selector-app branch from ee916fa to f330b0d Compare May 15, 2024 10:07
@ShGKme ShGKme marked this pull request as ready for review May 15, 2024 10:08
@ShGKme ShGKme requested a review from danxuliu May 15, 2024 10:09
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with search and deck, good job!

Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants