Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide text on mobile for TopBar only #12437

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image

🏁 Checklist

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right 🙈
LGTM but didnt test

@Antreesy Antreesy merged commit 4ff35d2 into main May 31, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/12383/mobile-call-button branch May 31, 2024 16:00
@nickvergessen
Copy link
Member

backport this and the first pr to 29?

@szaimen
Copy link
Contributor

szaimen commented Jun 8, 2024

/backport to stable29

Copy link

backportbot bot commented Jun 8, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/12437/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1d6ea36d

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/12437/stable29

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@nickvergessen
Copy link
Member

Was already added to the first backport by Maksim

@szaimen
Copy link
Contributor

szaimen commented Jun 9, 2024

Ah I see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants