-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mentions): prevent mention @all
for non moderators
#12618
feat(mentions): prevent mention @all
for non moderators
#12618
Conversation
@all
for non moderators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very excesive and complete pull request. Thanks a lot.
Had a quick look and most of it looks good, just some minor details.
Are you willing to also look into integration tests? Otherwise we can do that, no problem at all.
Thanks!
Yeah I'm looking for complete pull request including tests and docs |
b2e15a0
to
fb1e18c
Compare
fb1e18c
to
ec95041
Compare
src/components/ConversationSettings/ConversationSettingsDialog.vue
Outdated
Show resolved
Hide resolved
7ef581c
to
fca7fff
Compare
I'm working on tests and docs, I will update it soon. |
spreed/lib/Chat/ChatManager.php Lines 975 to 977 in 4d15425
Hi @nickvergessen, is this still in use? with this we do receive mention object through |
93fed77
to
590417b
Compare
It only is on the suggestions, so when you type |
This comment was marked as resolved.
This comment was marked as resolved.
eda1737
to
ca119f9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ca119f9
to
a81fcc7
Compare
a81fcc7
to
457a91e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Frontend review and we are ready to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine on the frontend side, just come nitpicks.
4b0c550
to
c000277
Compare
@nickvergessen sorry, I didn't updated local repo and directly force pushed, I recovered the changes but it will require your confirmation 😬 |
I'll rebase to solve the conflict and regenerate openapi |
I also invited you to our org, so you can send your branches to our org, so we can easier collaborate and CI works |
Signed-off-by: Sanskar Soni <sanskarsoni300@gmail.com>
Signed-off-by: Sanskar Soni <sanskarsoni300@gmail.com>
Signed-off-by: Sanskar Soni <sanskarsoni300@gmail.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
c000277
to
00cf77d
Compare
ok, really thanks, joined the org 🚀 |
☑️ Resolves
@all
for non-moderators #9074🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/
has been updated or is not required