-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔵 Use theming color as group and shared call colors instead of bland grey #1274
Conversation
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you help with that? :) Or how do I do that?
This wouldn’t look so good because it does become visible on hover/focus of the entry cause the background switches from white to grey. Or what do you mean? It’s fine if when you use white for theming, there’s simply seemingly no circle around the icon. No border needed. |
Of course! Let me help you by summoning @juliushaertl and @skjnldsv :-P
Mmmm, right, I did not think about that ;-)
👍 |
You need to use the icon color api and the .icon-link {
@include icon-color('link', 'places', $color-primary-text, 2, true);
} and so on :) |
In my opinion this makes it too colorful. |
I agree with @nickvergessen; if the primary colour is overused it loses its value to draw attention over the most important elements. I would be totally fine with the grey icons, but if you want to add more colour, maybe it would be better to use a light variant of the primary colour, or a slight variation on hue? Or maybe introduce a secondary colour, like the complimentary or one of the triads of the main colour? |
Closing as per above |
We might have discussed this, I think @Ivansss it was us? :) This makes it look much nicer instead of the default grey color:
Also much nicer in the dropdowns:
And for the email sharing, the icon is changed to white to fit better:
Please review @nextcloud/talk 🎉
Could you also adjust that in the mobile Talk apps cc @Ivansss @mario?