Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Participant): migrate to NcListItem #12819

Merged
merged 4 commits into from
Aug 6, 2024
Merged

fix(Participant): migrate to NcListItem #12819

merged 4 commits into from
Aug 6, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jul 25, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Screenshot before Screenshot after
image image
image image

🏁 Checklist

@Antreesy Antreesy added this to the 💙 Next Major (30) milestone Jul 25, 2024
@Antreesy Antreesy self-assigned this Jul 25, 2024
@nickvergessen

This comment was marked as resolved.

Sign in to view
@Antreesy

This comment was marked as resolved.

Sign in to view
@Antreesy Antreesy force-pushed the fix/noid/refactor-participant-item branch from 5796c13 to 3caff94 Compare August 3, 2024 09:05
@Antreesy
fix(Participant): refactor component
cde0889 
- replace v-tooltip with native title
- optimize icon render template
- simplify class names

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(Participant): replace inline NcActions with simple button
7aadacb 
- not supported by ListItem

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/refactor-participant-item branch from 3caff94 to b904ecc Compare August 5, 2024 16:14
@Antreesy Antreesy marked this pull request as ready for review August 5, 2024 16:15
@Antreesy Antreesy force-pushed the fix/noid/refactor-participant-item branch from b904ecc to 661b1fd Compare August 5, 2024 19:01
@Antreesy Antreesy mentioned this pull request Aug 5, 2024
Merged
5 tasks
DorraJaouad
DorraJaouad reviewed Aug 6, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is almost ready 🌟

src/components/RightSidebar/Participants/Participant.vue Outdated Show resolved Hide resolved
src/components/RightSidebar/Participants/Participant.vue Show resolved Hide resolved
src/components/RightSidebar/Participants/Participant.vue Outdated Show resolved Hide resolved
src/components/RightSidebar/Participants/Participant.vue Show resolved Hide resolved
@Antreesy Antreesy force-pushed the fix/noid/refactor-participant-item branch from 661b1fd to 8b2a46d Compare August 6, 2024 12:34
@Antreesy
fix(Participant): migrate to NcListItem
979164b 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(Participant): rename tooltip references to title
73499e6 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/refactor-participant-item branch from 8b2a46d to 73499e6 Compare August 6, 2024 13:11
DorraJaouad
DorraJaouad approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG 🦅

@Antreesy Antreesy merged commit 2018b17 into main Aug 6, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/refactor-participant-item branch August 6, 2024 14:06
@ShGKme
Copy link
Contributor

ShGKme commented Aug 7, 2024 •
edited by Antreesy
Loading

Follow-ups:

@Antreesy Antreesy mentioned this pull request Aug 14, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review feature: frontend 🖌️ "Web UI" client technical debt
Projects
None yet
Milestone
v20.0.0-beta.3
Development

Successfully merging this pull request may close these issues.
5 participants
@Antreesy @nickvergessen @ShGKme @DorraJaouad @danxuliu