fix(TopBar): align lines #12875
Merged
fix(TopBar): align lines #12875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
force-pushed
the
fix/top-bar--line-height
branch
from
df90b83
to
5743491
Compare
|
I don't think this is ok for accessibility. Could check that? |
With any solution it changes the top bar height, no matter what line height is set initially, if yuo mean this check.
|
ShGKme
force-pushed
the
fix/top-bar--line-height
branch
2 times, most recently
from
d6ef3b8
to
afea58c
Compare
|
Updated to normal font-size with normal line-height everywhere |
Antreesy
reviewed
Aug 5, 2024
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/top-bar--line-height
branch
from
afea58c
to
41e1e23
Compare
|
Antreesy
approved these changes
Aug 6, 2024
Antreesy
reviewed
Aug 6, 2024
| display: flex; | ||
| flex-wrap: wrap; | ||
| z-index: 10; | ||
| gap: 3px; | ||
| align-items: center; | ||
| justify-content: flex-end; | ||
| min-height: calc(2 * var(--default-grid-baseline) + var(--text-height) + var(--border-width)); | ||
| min-height: calc(var(--border-width) + 2 * (2 * var(--default-grid-baseline)) + var(--default-clickable-area)); |
There was a problem hiding this comment.
Call Container uses magic number 60 or close, need to be updated to the same value there too
There was a problem hiding this comment.
Ok, but I thought, we're going for variables)
There was a problem hiding this comment.
I found it more complex and risky. CallView is used in different entrypoints and not directly related to TopBar
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
|
Follow-up: use CSS variables in call view |
This was referenced Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
line-heightone-line is 1.5 height of fontnormal(about 1.2) line height ensures that the text is not cut off but also has no extra height even with normal font-size🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist