Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update PR template #12967

Merged
merged 1 commit into from
Aug 14, 2024
Merged

chore: update PR template #12967

merged 1 commit into from
Aug 14, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • long commit descriptions are not blended with first line of template anymore
  • checkboxes for different clients are separated now

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Screenshot before Screenshot after

🚧 Tasks

  • ...

🏁 Checklist


🛠️ API Checklist

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

- long commit descriptions are not blended with first line of template anymore
- Checkboxes for different clients are separated now

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Aug 14, 2024
@Antreesy Antreesy requested a review from nickvergessen August 14, 2024 13:50
@Antreesy Antreesy self-assigned this Aug 14, 2024
@Antreesy Antreesy merged commit fb4e297 into main Aug 14, 2024
45 checks passed
@Antreesy Antreesy deleted the chore/update-pr-template branch August 14, 2024 15:36
@Antreesy
Copy link
Contributor Author

  • long commit descriptions are not blended with first line of template anymore

Didn't work 😕

image

@nickvergessen
Copy link
Member

but... that's your sign off... I never have issues with my sign off and in fact it gets cut away by github automatically?

Are you using a github browser addon maybe?

@Antreesy
Copy link
Contributor Author

Refined github could be the only related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants