fix(SelectableParticipant): restyle component #13017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
force-pushed
the
fix/noid/restyle-selectable-participant
branch
from
f3433f8 to
22601ff
Compare
ShGKme
requested changes
Aug 16, 2024
Comment on lines
23
to
33
| <span class="selectable-participant__content"> | ||
| <span class="selectable-participant__content-name"> | ||
| {{ participant.displayName }} | ||
| </span> | ||
| <span v-if="participant.statusMessage" | ||
| class="selectable-participant__content-subname"> | ||
| {{ participant.statusIcon + ' ' + participant.statusMessage }} | ||
| </span> | ||
| </span> | ||
|
|
||
| <IconCheck v-if="selected" class="selectable-participant__check-icon" :size="20" /> |
There was a problem hiding this comment.
It's sad, we cannot use Cannot we use NcListItem here? Because of the check mark? Even with extra actions slot?
There was a problem hiding this comment.
I thought the problem was in the <a> tag? Otherwise we can try to hide input in extra slot, I think
There was a problem hiding this comment.
Postponing until NcListItem is a11y-aproppriate to do that. Then we could migrate this component as well
There was a problem hiding this comment.
Yet, we are using NcListItem in selectable participants in new conversation dialog. Can we use the same ?
There was a problem hiding this comment.
Want to do it with separate pr, to split the changes
Antreesy
force-pushed
the
fix/noid/restyle-selectable-participant
branch
from
22601ff to
abe6b6c
Compare
ShGKme
reviewed
Aug 20, 2024
Antreesy
force-pushed
the
fix/noid/restyle-selectable-participant
branch
from
abe6b6c to
ce96b16
Compare
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/noid/restyle-selectable-participant
branch
from
ce96b16 to
570bc32
Compare
|
/backport to stable30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist