Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ConversationSettingsDialog): hide unused settings sections in 1-1 #13041

Merged
merged 1 commit into from
Aug 20, 2024
Merged

fix(ConversationSettingsDialog): hide unused settings sections in 1-1 #13041

merged 1 commit into from
Aug 20, 2024

Conversation

Antreesy
Copy link
Contributor

… and former 1-1 conversations

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Former 1-1 🏡 1-1 🏘️ Group
image image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client

@Antreesy
fix(ConversationSettingsDialog): hide unused settings sections in 1-1…
4ca195c 
… and former 1-1 conversations

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added 3. to review feature: settings ⚙️ Settings and config related issues feature: frontend 🖌️ "Web UI" client labels Aug 20, 2024
@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Aug 20, 2024
@Antreesy Antreesy requested a review from DorraJaouad August 20, 2024 11:52
@Antreesy Antreesy self-assigned this Aug 20, 2024
@Antreesy
Copy link
Contributor Author

/backport to stable30

@DorraJaouad
Copy link
Contributor

Now looking at it, do we even need moderation section in one to one and also former 1-1? no one is actually a moderator..

@Antreesy
Copy link
Contributor Author

in one to one

there are recording consent and message expiration subsections still needed, and I wasn't sure about Copy link button. So let's go with current approach for now

@Antreesy Antreesy merged commit da33226 into main Aug 20, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/12884/hide-settings-in-former-1-1 branch August 20, 2024 13:24
@backportbot backportbot bot mentioned this pull request Aug 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels
3. to review feature: frontend 🖌️ "Web UI" client feature: settings ⚙️ Settings and config related issues
Projects
None yet
Milestone
v21.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Conversation settings for former one-to-one conversations should be reduced
3 participants
@Antreesy @DorraJaouad @ShGKme