Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcListItem): force three-dot-menu (+ minor follow-ups) #13074

Merged
merged 5 commits into from
Aug 22, 2024
Merged

fix(NcListItem): force three-dot-menu (+ minor follow-ups) #13074

merged 5 commits into from
Aug 22, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Aug 21, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image

🏁 Checklist

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Aug 21, 2024
@Antreesy Antreesy self-assigned this Aug 21, 2024
@Antreesy Antreesy mentioned this pull request Aug 21, 2024
Open
45 tasks
@Antreesy
Copy link
Contributor Author

/backport to stable30

@Antreesy Antreesy changed the title fix(NcCounter): migrate to :count prop fix(NcList): force three-dot-menu (+ minor follow-ups) Aug 21, 2024
@Antreesy Antreesy changed the title fix(NcList): force three-dot-menu (+ minor follow-ups) fix(NcListItem): force three-dot-menu (+ minor follow-ups) Aug 21, 2024
@Antreesy Antreesy marked this pull request as draft August 21, 2024 17:09
@Antreesy
fix(NcListItem): force three-dot-menu in items
a271a9e 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(NcPasswordField): use :as-text prop
d52c454 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(NcNoteCard): use :text prop
583f85b 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(NcCounter): migrate to :count prop
452fed1 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(NcCounter): replace message count badge in call with plain dot
c9e76f5 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy marked this pull request as ready for review August 22, 2024 11:01
@Antreesy Antreesy requested a review from ShGKme August 22, 2024 11:01
@Antreesy
Copy link
Contributor Author

I hope that's fine to not crop icon around marker;

There are MessageText, Message and MessageBadge icons, but no MessageTextBadge to use here (and svg paths are crossing, so can't reliably make a custom SVG icon

DorraJaouad
DorraJaouad approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦅

@Antreesy Antreesy merged commit 5e850a1 into main Aug 22, 2024
47 of 48 checks passed
@Antreesy Antreesy deleted the fix/noid/vue-bump-followups branch August 22, 2024 13:18
@backportbot backportbot bot mentioned this pull request Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review feature: frontend 🖌️ "Web UI" client technical debt
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.

Move *Remove group and members* into an action menu (again)
3 participants
@Antreesy @ShGKme @DorraJaouad