Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(federation): ensure federation invites appear in store #13149

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🖌️ UI Checklist

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client

src/App.vue Outdated Show resolved Hide resolved
Signed-off-by: Antreesy <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/13146/accept-fed-from-notification branch from da1b732 to 57c6e9a Compare August 27, 2024 12:08
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notification is not fading at the moment. I think this needs some more work on the notifications app and then here.
We need a way to "cancelAction but with success" and that should then still call https://github.com/nextcloud/notifications/blob/535046031341e5caaa2a256c4e9da9345741713c/src/Components/Action.vue#L127-L129

@nickvergessen nickvergessen merged commit e225c7e into main Aug 27, 2024
46 checks passed
@nickvergessen nickvergessen deleted the fix/13146/accept-fed-from-notification branch August 27, 2024 15:32
@Antreesy
Copy link
Contributor Author

/backport to stable30

@Antreesy
Copy link
Contributor Author

/backport to stable29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not accept federated invites in notification
2 participants