Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(federation): Correctly handle decline in system messages #13150

Merged
merged 1 commit into from
Aug 27, 2024
Merged

fix(federation): Correctly handle decline in system messages #13150

merged 1 commit into from
Aug 27, 2024

Conversation

nickvergessen
Copy link
Member

☑️ Resolves

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review bug feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐 labels Aug 27, 2024
@nickvergessen nickvergessen added this to the 🖤 Next Major (31) milestone Aug 27, 2024
@nickvergessen nickvergessen self-assigned this Aug 27, 2024
@nickvergessen
Copy link
Member Author

/backport to stable30

Antreesy
Antreesy approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Though I don't remember if it was intended to omit @cloudId remote part in some messages and keep in another ( or it's just confusing because of the same actorId)

1 2
image image

@nickvergessen
fix(federation): Correctly handle decline in system messages
28238bf 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/13048/correctly-handle-deline-in-system-message branch from 2fb0def to 28238bf Compare August 27, 2024 15:13
@nickvergessen nickvergessen merged commit 5fbbbea into main Aug 27, 2024
68 checks passed
@nickvergessen nickvergessen deleted the bugfix/13048/correctly-handle-deline-in-system-message branch August 27, 2024 15:53
@backportbot backportbot bot mentioned this pull request Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@skalidindi53 skalidindi53 skalidindi53 approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages feature: federation 🌐
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.

Removing a federated participant has wrong message?
3 participants
@nickvergessen @Antreesy @skalidindi53