Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use provide/inject to pass values of devMode to CallView children #13187

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix: use provide/inject to pass values of devMode to CallView children #13187

merged 1 commit into from
Aug 30, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Aug 30, 2024 •
edited
Loading

☑️ Resolves

  • Fix screenshot mode a bit

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
Remote screen image

🏁 Checklist

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Aug 30, 2024
@Antreesy Antreesy self-assigned this Aug 30, 2024
@Antreesy
fix: use provide/inject to pass values of devMode to CallView children
0b67e32 
Signed-off-by: Antreesy <antreesy.web@gmail.com>
DorraJaouad
DorraJaouad approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@Antreesy Antreesy merged commit f9998b6 into main Aug 30, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/screenshot-mode branch August 30, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @ShGKme @DorraJaouad