Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move page visibility check to composable #13302

Merged
merged 1 commit into from
Sep 14, 2024
Merged

fix: move page visibility check to composable #13302

merged 1 commit into from
Sep 14, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Sep 14, 2024 •
edited
Loading

☑️ Resolves

  • Move a value handling from the store

🖌️ UI Checklist

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • ⛑️ Tests are included or not possible

@Antreesy
fix: move page visibility check to composable
60cb14e 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Sep 14, 2024
@Antreesy Antreesy self-assigned this Sep 14, 2024
DorraJaouad
DorraJaouad approved these changes Sep 14, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

src/components/MessagesList/MessagesList.vue Show resolved Hide resolved
@Antreesy Antreesy merged commit a6a9bda into main Sep 14, 2024
46 checks passed
@Antreesy Antreesy deleted the feat/noid/visibility-composable branch September 14, 2024 15:54
@Antreesy Antreesy mentioned this pull request Sep 14, 2024
Merged
@Antreesy
Copy link
Contributor Author

/backport to stable30

@backportbot backportbot bot mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme left review comments

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review feature: frontend 🖌️ "Web UI" client technical debt
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @ShGKme @DorraJaouad