Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore sidebar listeners behavior + migrate sidebarStore to Pinia 🍍 #13307

Merged
merged 5 commits into from
Sep 15, 2024

Conversation

Antreesy
Copy link
Contributor

β˜‘οΈ Resolves

  • Fix opening the sidebar from Viewer

πŸ–ŒοΈ UI Checklist

πŸ–ΌοΈ Screenshots / Screencasts

No visual changes

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • ⛑️ Tests are included or not possible

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Copy link
Contributor Author

/backport! e51e756 to stable30

@Antreesy Antreesy changed the title fix: restore sidebar listeners behavior fix: restore sidebar listeners behavior + migrate sidebarStore to Pinia 🍍 Sep 15, 2024
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested and works as before.

src/components/RightSidebar/RightSidebar.vue Show resolved Hide resolved
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy merged commit 9b1bfde into main Sep 15, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/sidebar-store branch September 15, 2024 13:11
@Antreesy
Copy link
Contributor Author

/backport to stable30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants