Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix: restore sidebar listeners behavior #13388

Merged
merged 1 commit into from
Sep 25, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main.js
Original file line number Diff line number Diff line change
@@ -118,7 +118,7 @@ const Sidebar = function() {
const waitForSidebarToBeOpen = function(sidebarElement, resolve) {
if ('ontransitionend' in sidebarElement) {
const resolveOnceSidebarWidthHasChanged = (event) => {
if (event.propertyName !== 'min-width' && event.propertyName !== 'width' && event.propertyName !== 'max-width') {
if (!['min-width', 'width', 'max-width', 'margin-right'].includes(event.propertyName)) {
return
}

@@ -156,7 +156,7 @@ Sidebar.prototype.open = function(path) {
store.commit('showSidebar')
this.state.file = path

const sidebarElement = document.getElementById('app-sidebar')
const sidebarElement = document.getElementById('app-sidebar') ?? document.getElementById('app-sidebar-vue')

// The Viewer adjusts its width to the sidebar width once the sidebar has
// been opened. The sidebar opens with an animation, so a delay is needed

Unchanged files with check annotations Beta

<!-- text -->
<blockquote v-if="!isFileShareWithoutCaption"
class="quote__main__text">
<p dir="auto">{{ shortenedQuoteMessage }}</p>

Check warning on line 59 in src/components/Quote.vue

GitHub Actions / NPM lint

Expected 1 line break after opening tag (`<p>`), but no line breaks found

Check warning on line 59 in src/components/Quote.vue

GitHub Actions / NPM lint

Expected 1 line break before closing tag (`</p>`), but no line breaks found
</blockquote>
</div>