Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(info.xml): add discussion URL #13407

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(info.xml): add discussion URL #13407

wants to merge 2 commits into from

Conversation

edward-ly
Copy link

Update and explicitly specify the discussion URL as the link in the app store page is outdated anyway.

Related PR: nextcloud/appstore#1496

Update and explicitly specify the discussion URL as the link in the app store page is outdated.

Signed-off-by: Edward Ly <contact@edward.ly>
Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration from categories to tags is currently ongoing, let's wait until that is finished to add the URL.

@nickvergessen
Copy link
Member

https://help.nextcloud.com/tag/spreed-app looks fine, so whatever is done in the appstore, the default URL should work for talk.

@SystemKeeper
Copy link
Contributor

Ah got the full picture now 😅 default will now be help.nextcloud.com. So if we want to directly go to the corresponding tag, we need the discussion tag … we can also use https://help.nextcloud.com/tag/talk-app

@edward-ly
Copy link
Author

Is it possible to have a consistent tag naming scheme so that the default URL can be something like https://help.nextcloud.com/tag/{app_id}? If not, I can just update the URL too.

Signed-off-by: Edward Ly <contact@edward.ly>
@edward-ly
Copy link
Author

Is it possible to have a consistent tag naming scheme so that the default URL can be something like https://help.nextcloud.com/tag/{app_id}? If not, I can just update the URL too.

@SystemKeeper URL is now updated, but I'd like to know if my suggestion above is possible for other apps that don't have a URL specified. If not, that's fine, we can just stick with help.nextcloud.com too.

@nickvergessen
Copy link
Member

Could we add a redirect on help so the old link forwards to the new one?

@edward-ly
Copy link
Author

Which is old and which is new?

@nickvergessen
Copy link
Member

Which is old and which is new?

Whatever is displayed on https://apps.nextcloud.com/apps/spreed atm and whatever should be displayed there in the future?

@edward-ly
Copy link
Author

Which is old and which is new?

Whatever is displayed on https://apps.nextcloud.com/apps/spreed atm and whatever should be displayed there in the future?

Whenever this PR is merged and a new release is pushed, the link in https://apps.nextcloud.com/apps/spreed should be automatically updated to use the link specified here. Or are you talking about a feature where https://help.nextcloud.com/c/apps/spreed automatically redirects to https://help.nextcloud.com/tag/talk-app?

@nickvergessen
Copy link
Member

Or are you talking about a feature where https://help.nextcloud.com/c/apps/spreed automatically redirects to https://help.nextcloud.com/tag/talk-app?

Not a feature, just a plain redirect on the web server, so that the old link doesn't lead to a wrong/404 place.

@SystemKeeper
Copy link
Contributor

All categories that are migrated have a permalink to the new destination.

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants