Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass token to callView store via actions #13625

Merged
merged 2 commits into from
Oct 24, 2024
Merged

fix: pass token to callView store via actions #13625

merged 2 commits into from
Oct 24, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Fix broken public share sidebar
  • init => import Vuex => import Pinia => import Vuex - breaking loop that should be avoided (until everything is migrated)

⚠️ server master branch (31) has now different behaviour for public shares, so testable only on stable30 (see backport)

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Errors in console Working as expected

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • ⛑️ Tests are included or not possible

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Oct 24, 2024
@Antreesy Antreesy self-assigned this Oct 24, 2024
@Antreesy
fix: pass token to callView store via actions
2f19f82 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/vuex-pinia-loop branch from c0a4909 to 4c6f65a Compare October 24, 2024 13:02
@Antreesy
Copy link
Contributor Author

/backport! to stable30

@backportbot backportbot bot mentioned this pull request Oct 24, 2024
Merged
DorraJaouad
DorraJaouad approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, circular dependency was removed

@Antreesy
fix: pass conversation to callView store via actions
6bf5c09 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/vuex-pinia-loop branch from 4c6f65a to 6bf5c09 Compare October 24, 2024 14:05
@Antreesy Antreesy enabled auto-merge October 24, 2024 14:06
@Antreesy Antreesy merged commit 7e3a73b into main Oct 24, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/vuex-pinia-loop branch October 24, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v21.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @DorraJaouad