Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove room information for users which are not a participant #1502

Merged

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jan 31, 2019

This requires adjustment in the android app, as it breaks the conversation info.
The information should be fetched after joining the conversation only.

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants mobile apps labels Jan 31, 2019
@nickvergessen nickvergessen added this to the 💚 Next Major milestone Jan 31, 2019
Signed-off-by: Joas Schilling <coding@schilljs.com>
@mario
Copy link
Contributor

mario commented Feb 2, 2019

I'm looking at this first thing Monday.

Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@nickvergessen
Copy link
Member Author

/backport to stable15

@nickvergessen nickvergessen merged commit 5a5cd48 into master Feb 7, 2019
@nickvergessen nickvergessen deleted the bugfix/noid/remove-room-information-unless-authenticated branch February 7, 2019 07:11
@backportbot-nextcloud
Copy link

backport to stable15 in #1518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants