Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay message sending when socket is null #1549

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Delay message sending when socket is null #1549

merged 1 commit into from
Feb 18, 2019

Conversation

nickvergessen
Copy link
Member

We had 648 log entries for this in sentry since dec 2018:

TypeError

this.socket is null

@nickvergessen
Delay message sending when socket is null
e648626 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 3. to review bug feature: signaling 📶 Internal and external signaling backends labels Feb 18, 2019
@nickvergessen nickvergessen added this to the 💚 Next Major milestone Feb 18, 2019
@nickvergessen
Copy link
Member Author

/backport to stable15

@nickvergessen
Copy link
Member Author

/backport to stable14

@nickvergessen
Copy link
Member Author

@fancycode can you take a quick look and say if this should be okay?

fancycode
fancycode approved these changes Feb 18, 2019
View reviewed changes
Copy link
Member

@fancycode fancycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@nickvergessen nickvergessen merged commit d5de485 into master Feb 18, 2019
@nickvergessen nickvergessen deleted the bugfix/noid/socket-is-null branch February 18, 2019 16:35
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 18, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable15 in #1551

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 18, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable14 in #1552

@nickvergessen nickvergessen mentioned this pull request Mar 22, 2019
Merged
3 tasks
@nickvergessen nickvergessen mentioned this pull request Apr 10, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fancycode fancycode fancycode approved these changes

Assignees
No one assigned
Labels
3. to review bug feature: signaling 📶 Internal and external signaling backends
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @fancycode