Fix disabling video when joining a call in a room with more than five participants #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable15 |
Until now, when entering a room with more than five participants the video was disabled. However, if the local video is available it is enabled when WebRTC starts. Due to this, if WebRTC was also started when joining the call (that is, no previous calls were made in other rooms since the last page reload) the video was enabled instead of disabled. Besides that, if leaving the call with the video enabled and joining it again the video was still enabled, as the room had not been entered again to disable the video. To fix both issues now the video is disabled when joining the call instead of when entering the room. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
When calling "disableVideo" the video was hidden even if it was not possible to disable the video; this was done to hide the video even if WebRTC was not started yet when "disableVideo" was called. Now that the video is disabled when joining the call in a room with more than five participants instead of just when entering a room with more than five participants that special behaviour is no longer needed. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
fix-disabling-video-when-joining-a-call-in-a-room-with-more-than-five-participants
branch
from
cef2f24 to
726eb60
Compare
nickvergessen
approved these changes
Feb 25, 2019
nickvergessen
deleted the
fix-disabling-video-when-joining-a-call-in-a-room-with-more-than-five-participants
branch
|
backport to stable15 in #1578 |
25 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test
Result with this pull request:
Local video is disabled.
Result without this pull request:
Local video is enabled.